Skip to content

Increase query resolver's function arguments: 9 to 19 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Increase query resolver's function arguments: 9 to 19 #172

wants to merge 4 commits into from

Conversation

ima9dan
Copy link

@ima9dan ima9dan commented Dec 7, 2021

The maximum function argument for the query resolver was 9.
However, there were cases where that was not enough, so I added it.

example

query ("test") {
    description = "test"
    resolver {
        arg1:String?, arg2:String?, arg3:String?, arg4:String?, arg5:String?, arg6:String?, arg7:String?,
            arg8:String?, arg9:String?, arg10:String?, arg11:String?,arg12:String?,arg13:String?,arg14:String?,
            arg15:String?, arg16:String?, arg17:String?, arg18:String?, arg19:String? ->

        true
    }
}

@xplayerCZ
Copy link

Isn't grouping arguments in object a better way to approach this issue? Like Filter, Sort etc. This number of arguments seems brutal for production use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ima9dan @xplayerCZ